Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameINI: Fix tattoo texture saving in Rabbids Go Home #13013

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duckymomo360
Copy link

Saving rabbid with EFB Copies to Texture Only:
Rabbid's texture is saved as fully black.
image

Saving rabbid without EFB Copies to Texture Only:
Intended behavior.
image

@JosJuice
Copy link
Member

@JMC47 What do you think? Is this worth the performance impact, considering it's something you could toggle just when saving the Rabbid?

@Tilka
Copy link
Member

Tilka commented Aug 16, 2024

The impact is small but some areas are already not running at full speed, at least not on my computer.

@JMC47
Copy link
Contributor

JMC47 commented Aug 19, 2024

This is one of those cases where I wish we had a Accuracy vs Performance INI option. I lean toward merging it, but I'm not sure.

@duckymomo360
Copy link
Author

I've never noticed a performance impact in this game with this hack disabled, at least on my hardware.
I'd also like to add that people can actually put a lot of time/effort into customizing their rabbid (as dumb as that sounds), and there's absolutely no warning that all of your progress will be immediately erased as soon as you exit the editor if you're using default dolphin settings. It can be pretty upsetting for people unfamiliar with how the game behaves on dolphin.

@iwubcode
Copy link
Contributor

Assuming I haven't reduced the performance benefits with GM2.0 then this is probably another one for #12156 when I can get back to it.. (adding to remind myself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants